Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue where the section height on the about section had different spacing between top and bottom areas #77

Conversation

inovux
Copy link

@inovux inovux commented Oct 14, 2021

closes issue #61

Description

The spacing on the about page was wrong, the top side had more white space than the bottom. This PR will fix this issue.

@vercel
Copy link

vercel bot commented Oct 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/varun-singhh/vovoca/4ZB5gSjWd3bdiscaMu5vDKTfi8ix
✅ Preview: https://vovoca-git-fork-inovux-fix-issue-with-about-a62042-varun-singhh.vercel.app

@inovux
Copy link
Author

inovux commented Oct 18, 2021

@varun-singhh Could you review my PR :)?

@kaustubhai
Copy link
Collaborator

Hey @inovux, I cannot see how is this solving the problem. Can you elaorate

@inovux
Copy link
Author

inovux commented Oct 19, 2021

@kaustubhai sorry I guess I forgot one of the media queries used on mobile

@inovux
Copy link
Author

inovux commented Oct 19, 2021

@kaustubhai the spacing should be the same now on all screen sizes. If this is still incorrect can you please explain then what it is you want to be fixed because I have no idea then:)

@kaustubhai
Copy link
Collaborator

See the spacing on all screen sizes is same, but it is not according to the design.
In a div, the content should have equal top and bottom padding right? However it does not seem to be the case with this div.
Let me know if still it is not clear

@inovux
Copy link
Author

inovux commented Oct 21, 2021

@kaustubhai if it is not according to the design, then where can I find the design so I can adjust it?

@varun-singhh
Copy link
Owner

@inovux your PR is not valid. Actually, you are behind the master branch, first, you need to pull from the master branch then edit the changes as mentioned by @kaustubhai

@inovux
Copy link
Author

inovux commented Oct 22, 2021

@varun-singhh I understand its not valid. But not sure what the design should be looking like exactly? How big should the spacing be and where is the spacing off exactly? I cannot really figure out what has to be done here.

@varun-singhh
Copy link
Owner

Surely will let you know the requirements within 48hrs

@varun-singhh
Copy link
Owner

@varun-singhh I understand its not valid. But not sure what the design should be looking like exactly? How big should the spacing be and where is the spacing off exactly? I cannot really figure out what has to be done here.

@kaustubhai please look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants