-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Issue where the section height on the about section had different spacing between top and bottom areas #77
Conversation
…t spacing between top and bottom areas
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/varun-singhh/vovoca/4ZB5gSjWd3bdiscaMu5vDKTfi8ix |
@varun-singhh Could you review my PR :)? |
Hey @inovux, I cannot see how is this solving the problem. Can you elaorate |
@kaustubhai sorry I guess I forgot one of the media queries used on mobile |
@kaustubhai the spacing should be the same now on all screen sizes. If this is still incorrect can you please explain then what it is you want to be fixed because I have no idea then:) |
See the spacing on all screen sizes is same, but it is not according to the design. |
@kaustubhai if it is not according to the design, then where can I find the design so I can adjust it? |
@inovux your PR is not valid. Actually, you are behind the master branch, first, you need to pull from the master branch then edit the changes as mentioned by @kaustubhai |
@varun-singhh I understand its not valid. But not sure what the design should be looking like exactly? How big should the spacing be and where is the spacing off exactly? I cannot really figure out what has to be done here. |
Surely will let you know the requirements within 48hrs |
@kaustubhai please look into it. |
closes issue #61
Description
The spacing on the about page was wrong, the top side had more white space than the bottom. This PR will fix this issue.