Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Redis Sendable #217

Merged
merged 1 commit into from
Feb 20, 2025
Merged

make Redis Sendable #217

merged 1 commit into from
Feb 20, 2025

Conversation

AntVil
Copy link
Contributor

@AntVil AntVil commented Feb 19, 2025

These changes are now available in 4.11.1

  • counter warning from Application.Redis: Stored property 'redisInstances' of 'Sendable'-conforming class 'MyRedis' has non-sendable type '[Application.Redis]'; this is an error in the Swift 6 language mode

example for more context:

extension Application {
    public final class MyRedis {
        struct MyRedisKey: StorageKey {
            typealias Value = Application.MyRedis
        }

        private let redisInstances: [Application.Redis]
    }
}

@AntVil AntVil requested review from 0xTim and gwynne as code owners February 19, 2025 15:07
@0xTim 0xTim added the semver-patch Internal changes only label Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.33%. Comparing base (383ed57) to head (eb23c9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   52.88%   53.33%   +0.45%     
==========================================
  Files          11       11              
  Lines         399      420      +21     
==========================================
+ Hits          211      224      +13     
- Misses        188      196       +8     
Files with missing lines Coverage Δ
Sources/Redis/Application+Redis.swift 41.46% <ø> (ø)

... and 6 files with indirect coverage changes

@0xTim 0xTim merged commit b452702 into vapor:main Feb 20, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants