Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL support for nested subpath (JSON) expressions #321

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Jul 10, 2023

Implements SQLKit's new SQLDialect.nestedSubpathExpression(in:for:) method.

@gwynne gwynne added the semver-patch Internal changes only label Jul 10, 2023
@gwynne gwynne requested review from 0xTim and MahdiBM July 10, 2023 14:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Merging #321 (e7291ba) into main (d944fb3) will increase coverage by 2.33%.
The diff coverage is 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   58.52%   60.85%   +2.33%     
==========================================
  Files           8        8              
  Lines         352      281      -71     
==========================================
- Hits          206      171      -35     
+ Misses        146      110      -36     
Impacted Files Coverage Δ
Sources/MySQLKit/MySQLDialect.swift 68.33% <80.00%> (+7.46%) ⬆️

... and 7 files with indirect coverage changes

@gwynne gwynne merged commit 5904a6f into main Jul 11, 2023
@gwynne gwynne deleted the nested-subpath-expressions branch July 11, 2023 06:24
@VaporBot
Copy link

These changes are now available in 4.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants