Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip IPv6 tests when TCLSH version is < 8.6 #910

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Skip IPv6 tests when TCLSH version is < 8.6 #910

merged 3 commits into from
Aug 15, 2024

Conversation

enjoy-binbin
Copy link
Member

@enjoy-binbin enjoy-binbin commented Aug 14, 2024 •
edited
Loading

In #786, we did skip it in the daily, but not for the others.
When running ./runtest on MacOS, we will get the failure.

couldn't open socket: host is unreachable (nodename nor servname provided, or not known)

TCL 8.5 doesn't support ipv6, skip tests tagged with ipv6.
This also revert #786.

@enjoy-binbin
Skip IPv6 tests on MacOS
d0b9232 
In valkey-io#786, we did skip it in the daily, but not for the others.
When running ./runtest on MacOS, we will get the failure.
```
couldn't open socket: host is unreachable (nodename nor servname provided, or not known)
```

This PR moves the skip logic from tags -ipv6 to TCL uname.
This also revert valkey-io#786.

Signed-off-by: Binbin <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.16%. Comparing base (131857e) to head (29db674).
Report is 63 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable     #910      +/-   ##
============================================
- Coverage     70.37%   70.16%   -0.21%     
============================================
  Files           112      112              
  Lines         61492    61489       -3     
============================================
- Hits          43273    43144     -129     
- Misses        18219    18345     +126

see 15 files with indirect coverage changes

hpatro
hpatro approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@hpatro hpatro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks must have been bothering devs using MacOS as well. Why does it not work on MacOS though?

@madolson
Copy link
Member

madolson commented Aug 14, 2024 •
edited
Loading

Thanks must have been bothering devs using MacOS as well. Why does it not work on MacOS though?

By default macos has tcl 8.5 installed, which doesn't support ipv6. If you do brew install tcl-tk it does work on 8.6. I guess we could skip it based off of that?

zuiderkwast
zuiderkwast reviewed Aug 14, 2024
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the check wherever tags are checked in the test framework, instead of in this test suite?

If tcl < 8.6, skip tests tagged with ipv6.

@enjoy-binbin enjoy-binbin changed the title Skip IPv6 tests on MacOS Skip IPv6 tests when TCLSH version is < 8.6 Aug 15, 2024
@enjoy-binbin enjoy-binbin merged commit 76ad8f7 into valkey-io:unstable Aug 15, 2024
46 checks passed
@enjoy-binbin enjoy-binbin deleted the skip_ipv6 branch August 15, 2024 07:11
mapleFU pushed a commit to mapleFU/valkey that referenced this pull request Aug 21, 2024
@enjoy-binbin @mapleFU
Skip IPv6 tests when TCLSH version is < 8.6 (valkey-io#910)
4096ad2 
In valkey-io#786, we did skip it in the daily, but not for the others.
When running ./runtest on MacOS, we will get the failure.
```
couldn't open socket: host is unreachable (nodename nor servname provided, or not known)
```

The reason is that TCL 8.5 doesn't support ipv6, so we skip tests
tagged with ipv6. This also revert valkey-io#786.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: mwish <[email protected]>
mapleFU pushed a commit to mapleFU/valkey that referenced this pull request Aug 22, 2024
@enjoy-binbin @mapleFU
Skip IPv6 tests when TCLSH version is < 8.6 (valkey-io#910)
cfd65f6 
In valkey-io#786, we did skip it in the daily, but not for the others.
When running ./runtest on MacOS, we will get the failure.
```
couldn't open socket: host is unreachable (nodename nor servname provided, or not known)
```

The reason is that TCL 8.5 doesn't support ipv6, so we skip tests
tagged with ipv6. This also revert valkey-io#786.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: mwish <[email protected]>
@enjoy-binbin enjoy-binbin mentioned this pull request Aug 29, 2024
Merged
madolson pushed a commit that referenced this pull request Sep 2, 2024
@enjoy-binbin @madolson
Skip IPv6 tests when TCLSH version is < 8.6 (#910)
afce71c 
In #786, we did skip it in the daily, but not for the others.
When running ./runtest on MacOS, we will get the failure.
```
couldn't open socket: host is unreachable (nodename nor servname provided, or not known)
```

The reason is that TCL 8.5 doesn't support ipv6, so we skip tests
tagged with ipv6. This also revert #786.

Signed-off-by: Binbin <[email protected]>
madolson pushed a commit that referenced this pull request Sep 3, 2024
@enjoy-binbin @madolson
Skip IPv6 tests when TCLSH version is < 8.6 (#910)
0aca1a9 
In #786, we did skip it in the daily, but not for the others.
When running ./runtest on MacOS, we will get the failure.
```
couldn't open socket: host is unreachable (nodename nor servname provided, or not known)
```

The reason is that TCL 8.5 doesn't support ipv6, so we skip tests
tagged with ipv6. This also revert #786.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin added the release-notes This issue should get a line item in the release notes label Sep 4, 2024
PingXie added a commit to PingXie/valkey that referenced this pull request Sep 14, 2024
@PingXie
Skip IPv6 tests when TCLSH version is < 8.6 (valkey-io#910)
1f18571 
In valkey-io#786, we did skip it in the daily, but not for the others.
When running ./runtest on MacOS, we will get the failure.
```
couldn't open socket: host is unreachable (nodename nor servname provided, or not known)
```

The reason is that TCL 8.5 doesn't support ipv6, so we skip tests
tagged with ipv6. This also revert valkey-io#786.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie added a commit to PingXie/valkey that referenced this pull request Sep 14, 2024
@PingXie
Skip IPv6 tests when TCLSH version is < 8.6 (valkey-io#910)
fb680fa 
In valkey-io#786, we did skip it in the daily, but not for the others.
When running ./runtest on MacOS, we will get the failure.
```
couldn't open socket: host is unreachable (nodename nor servname provided, or not known)
```

The reason is that TCL 8.5 doesn't support ipv6, so we skip tests
tagged with ipv6. This also revert valkey-io#786.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
PingXie added a commit to PingXie/valkey that referenced this pull request Sep 14, 2024
@PingXie
Skip IPv6 tests when TCLSH version is < 8.6 (valkey-io#910)
3b4b8b2 
In valkey-io#786, we did skip it in the daily, but not for the others.
When running ./runtest on MacOS, we will get the failure.
```
couldn't open socket: host is unreachable (nodename nor servname provided, or not known)
```

The reason is that TCL 8.5 doesn't support ipv6, so we skip tests
tagged with ipv6. This also revert valkey-io#786.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
hpatro pushed a commit to hpatro/valkey that referenced this pull request Jan 7, 2025
@enjoy-binbin @hpatro
Skip IPv6 tests when TCLSH version is < 8.6 (valkey-io#910)
a691cb3 
In valkey-io#786, we did skip it in the daily, but not for the others.
When running ./runtest on MacOS, we will get the failure.
```
couldn't open socket: host is unreachable (nodename nor servname provided, or not known)
```

The reason is that TCL 8.5 doesn't support ipv6, so we skip tests
tagged with ipv6. This also revert valkey-io#786.

Signed-off-by: Binbin <[email protected]>
hpatro pushed a commit that referenced this pull request Jan 8, 2025
@enjoy-binbin @hpatro
Skip IPv6 tests when TCLSH version is < 8.6 (#910)
e59525f 
In #786, we did skip it in the daily, but not for the others.
When running ./runtest on MacOS, we will get the failure.
```
couldn't open socket: host is unreachable (nodename nor servname provided, or not known)
```

The reason is that TCL 8.5 doesn't support ipv6, so we skip tests
tagged with ipv6. This also revert #786.

Signed-off-by: Binbin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madolson madolson madolson approved these changes

@zuiderkwast zuiderkwast zuiderkwast approved these changes

@hpatro hpatro hpatro approved these changes

Assignees
No one assigned
Labels
release-notes This issue should get a line item in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enjoy-binbin @madolson @zuiderkwast @hpatro