Input output traffic stats and command process count for each client. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Tianjie <[email protected]>
madolson
reviewed
Apr 17, 2024
|
@valkey-io/core-team Please 👍 and 👎 for this since it's a major issue. |
Signed-off-by: Chen Tianjie <[email protected]>
CharlesChen888
force-pushed
the
client-traffic-stat
branch
from
f2c2dd7 to
94da8db
Compare
Signed-off-by: Chen Tianjie <[email protected]>
Signed-off-by: Chen Tianjie <[email protected]>
zuiderkwast
reviewed
Apr 18, 2024
madolson
added
major-decision-approved
madolson
reviewed
Apr 19, 2024
madolson
reviewed
Apr 19, 2024
madolson
added
the
needs-doc-pr
Signed-off-by: Chen Tianjie <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #327 +/- ##
===========================================
Coverage ? 68.40%
===========================================
Files ? 108
Lines ? 61571
Branches ? 0
===========================================
Hits ? 42118
Misses ? 19453
Partials ? 0
|
|
OK, besides the one comment about |
Signed-off-by: Chen Tianjie <[email protected]>
Signed-off-by: Chen Tianjie <[email protected]>
|
@madolson Any more comments? I think this PR is ready to merge. |
madolson
approved these changes
May 6, 2024
madolson
added
the
release-notes
madolson
pushed a commit
to valkey-io/valkey-doc
that referenced
this pull request
May 6, 2024
Corresponding doc PR to valkey-io/valkey#327. * `tot-net-in`: Total network input bytes read from this client. Added in Valkey 8.0 * `tot-net-out`: Total network output bytes sent to this client. Added in Valkey 8.0 * `tot-cmds`: Total count of commands this client executed. Added in Valkey 8.0 --------- Signed-off-by: Chen Tianjie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have global stats for input traffic, output traffic and how many commands have been executed.
However, some users have the difficulty of locating the IP(s) which have heavy network traffic. So here some stats for single client are introduced.
These three stats are shown in
CLIENT LISTandCLIENT INFO.Though the metrics are handled in hot paths of the code, personally I don't think it will slow down the server. Considering all other complex operations handled nearby, this is only a small and simple operation.
However we do need to be cautious when adding more and more metrics, as discussed in redis/redis#12640, we may need to find a way to tell whether this has obvious performance degradation.