Going back to custom uk.org.lidalia.lang.ThreadLocal in some classes #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
approved these changes
Mar 29, 2022
|
Code Climate has analyzed commit ce301e9 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going back to the custom ThreadLocal implementation (
uk.org.lidalia.lang.ThreadLocal) in order to prevent memory leaks.The classes in which the custom ThreadLocal should be used are TestLogger and TestLoggerFactory which hold the loggingEvents attribute that contains LoggingEvent instances. On TestMDCAdapter it's not necessary since the ThreadLocal attribute (
value) contains a Map of String keys and values, not LoggingEvents.As requested by @valfirst, in order not to add an extra dependency, I'm copying the original implementation from https://github.com/Mahoney/lidalia-lang giving credit to the author in the comments.
Closes #255