You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At least two places, nulls are replaced by other values:
When a LoggingEvent is constructed with arguments, nulls are replaced by Option.empty()
If a null value is inserted in the MDC, it replaced by the string "null".
I am not sure what was the rationale for implementing it like this. For the first case, it may beacuse the original author wanted to use the Guava ImmutableList. But it also seems that he had a dislike for null in general.
If you just compare logging events, the first has no impact, but if you are testing MDC functionality, the second could be annoying. In particular, the assertion failure message shows null in both the expected and the actual value.
I can quickly make a PR to change this if you think it is a good idea.
The text was updated successfully, but these errors were encountered:
At least two places, nulls are replaced by other values:
LoggingEvent
is constructed with arguments, nulls are replaced byOption.empty()
"null"
.I am not sure what was the rationale for implementing it like this. For the first case, it may beacuse the original author wanted to use the Guava
ImmutableList
. But it also seems that he had a dislike fornull
in general.If you just compare logging events, the first has no impact, but if you are testing MDC functionality, the second could be annoying. In particular, the assertion failure message shows
null
in both the expected and the actual value.I can quickly make a PR to change this if you think it is a good idea.
The text was updated successfully, but these errors were encountered: