fix: make MenuAccessControl availalble in mocking environment

vaadin-testbench-unit-junit5/src/test/java/com/vaadin/testbench/unit/SecurityTestConfig.java

@@ -23,6 +23,8 @@
 
 import com.vaadin.flow.router.RouteConfiguration;
 import com.vaadin.flow.server.VaadinServiceInitListener;
+import com.vaadin.flow.server.auth.DefaultMenuAccessControl;
+import com.vaadin.flow.server.auth.MenuAccessControl;
 import com.vaadin.flow.server.auth.NavigationAccessControl;
 import com.vaadin.flow.server.auth.ViewAccessChecker;
 
@@ -88,5 +90,33 @@ public UserDetails loadUserByUsername(String username)
                 }
             };
         }
+
+        @Bean
+        MenuAccessControl menuAccessControl() {
+            // SpringMenuAccessControl has been introduced in Vaadin 24.5
+            // but the Testbench codebase currently supports also 24.4
+            // Using reflection to prevent runtime issues.
+            Class<? extends MenuAccessControl> clazz = springMenuAccessControlClass();
+            if (clazz != null) {
+                try {
+                    return clazz.getConstructor().newInstance();
+                } catch (Exception e) {
+                    throw new AssertionError(
+                            "Cannot instantiate SpringMenuAccessControl");
+                }
+            }
+            return new DefaultMenuAccessControl();
+        }
+    }
+
+    @SuppressWarnings("unchecked")
+    static Class<? extends MenuAccessControl> springMenuAccessControlClass() {
+        try {
+            return (Class<? extends MenuAccessControl>) Class.forName(
+                    "com.vaadin.flow.spring.security.SpringMenuAccessControl");
+        } catch (ClassNotFoundException e) {
+            // No op
+        }
+        return null;
     }
 }

vaadin-testbench-unit-junit5/src/test/java/com/vaadin/testbench/unit/SpringUnitSecurityTest.java

@@ -13,13 +13,16 @@
 import com.testapp.security.LoginView;
 import com.testapp.security.ProtectedView;
 import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Assumptions;
 import org.junit.jupiter.api.Test;
 import org.springframework.security.test.context.support.WithAnonymousUser;
 import org.springframework.security.test.context.support.WithMockUser;
 import org.springframework.security.test.context.support.WithUserDetails;
 import org.springframework.test.context.ContextConfiguration;
 
 import com.vaadin.flow.server.VaadinRequest;
+import com.vaadin.flow.server.VaadinService;
+import com.vaadin.flow.server.auth.MenuAccessControl;
 
 @ContextConfiguration(classes = SecurityTestConfig.NavigationAccessControlConfig.class)
 @ViewPackages(packages = "com.testapp.security")
@@ -101,4 +104,21 @@ void withAnonymousUser_redirectToLogin() {
                 "Anonymous user should be redirect to login view");
     }
 
+    @Test
+    void extendingBaseClass_runTest_menuAccessControlAvailable() {
+        Class<? extends MenuAccessControl> menuAccessControlClass = SecurityTestConfig
+                .springMenuAccessControlClass();
+        Assumptions.assumeTrue(menuAccessControlClass != null,
+                "SpringMenuAccessControl class not available");
+        MenuAccessControl menuAccessControl = VaadinService.getCurrent()
+                .getInstantiator().getMenuAccessControl();
+        Assertions.assertNotNull(menuAccessControl,
+                "Expecting MenuAccessControl to be available");
+        Assertions.assertInstanceOf(menuAccessControlClass, menuAccessControl,
+                "Expecting menu access control to be "
+                        + menuAccessControlClass.getName() + " but was "
+                        + menuAccessControl.getClass().getName());
+
+    }
+
 }

vaadin-testbench-unit-junit5/src/test/java/com/vaadin/testbench/unit/UIUnitBaseClassTest.java

@@ -28,6 +28,7 @@
 import com.vaadin.flow.server.VaadinResponse;
 import com.vaadin.flow.server.VaadinService;
 import com.vaadin.flow.server.VaadinSession;
+import com.vaadin.flow.server.auth.MenuAccessControl;
 
 class UIUnitBaseClassTest {
 
@@ -101,4 +102,17 @@ void customService_availableInLookup() {
         }
     }
 
+    @Nested
+    class MenuAccessControlTest extends UIUnitTest {
+
+        @Test
+        void menuAccessControl_instanceAvailable() {
+            MenuAccessControl menuAccessControl = VaadinService.getCurrent()
+                    .getInstantiator().getMenuAccessControl();
+            Assertions.assertNotNull(menuAccessControl,
+                    "Expecting MenuAccessControl to be available");
+
+        }
+    }
+
 }

vaadin-testbench-unit-shared/src/main/kotlin/com/vaadin/testbench/unit/mocks/MockInstantiator.kt

@@ -11,6 +11,7 @@ package com.vaadin.testbench.unit.mocks
 
 import com.vaadin.flow.di.Instantiator
 import com.vaadin.flow.i18n.I18NProvider
+import com.vaadin.flow.server.auth.MenuAccessControl
 import net.bytebuddy.ByteBuddy
 import net.bytebuddy.implementation.MethodCall
 import net.bytebuddy.matcher.ElementMatchers
@@ -31,6 +32,8 @@ open class MockInstantiator(val delegate: Instantiator) : Instantiator by delega
         else -> delegate.getOrCreate(type)
     }
 
+    override fun getMenuAccessControl(): MenuAccessControl = delegate.menuAccessControl
+
     override fun getI18NProvider(): I18NProvider? = delegate.i18NProvider
 
     companion object {