fix: Disable Chrome's search engine selection dialogue in LocalDriver #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search engine selection dialogue doesn't affect testing, or show up in screenshots, but it makes local debugging difficult by hiding content visually.
thevaadinman
approved these changes
Aug 14, 2024
|
Why was this done and merged for 5.3 when the workflow is always to merge into main and backport when needed? |
|
Because different teams maintain the V8/7 branches and the Flow branches, and because this issue was blocking my attempts to test another issue in another project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search engine selection dialogue doesn't affect testing, or show up in screenshots, but it makes local debugging difficult by hiding content visually.