Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: amend JDT-reported errors #3348

Merged
merged 5 commits into from
Mar 20, 2025
Merged

chore: amend JDT-reported errors #3348

merged 5 commits into from
Mar 20, 2025

Conversation

cromoteca
Copy link
Contributor

@cromoteca cromoteca commented Mar 14, 2025

JDT (Eclipse engine also found in VS Code Java support) reports some errors that are not marked as such by the JDK.

While they compile successfully, it happened to me sometimes that they block IDEA test execution, needing a rebuild to pass.

Given the annoyances, I propose some code changes that solve those issues without changes in functionality.

image

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.92%. Comparing base (08d0630) to head (ad66270).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
+ Coverage   86.89%   86.92%   +0.02%     
==========================================
  Files         115      115              
  Lines        8289     8289              
  Branches     1271     1271              
==========================================
+ Hits         7203     7205       +2     
+ Misses       1072     1070       -2     
  Partials       14       14              
Flag Coverage Δ
unittests 86.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@platosha platosha merged commit 6151dbd into main Mar 20, 2025
15 of 16 checks passed
@platosha platosha deleted the fix-jdt-reported-errors branch March 20, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants