Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove tokenFile after production build #20346

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: remove tokenFile after production build #20346

merged 1 commit into from
Oct 30, 2024

Conversation

caalador
Copy link
Contributor

Clean the token file after
production build/execution
to not make ide app execution
run app in production mode.

Closes #20294

Clean the token file after
production build/execution
to not make ide app execution
run app in production mode.

Closes #20294
Copy link

Copy link

Test Results

1 142 files  + 1  1 142 suites  +1   1h 27m 27s ⏱️ + 2m 56s
7 474 tests + 1  7 424 ✅ ± 0  50 💤 +1  0 ❌ ±0 
7 847 runs  +24  7 787 ✅ +23  60 💤 +1  0 ❌ ±0 

Results for commit 8b262c1. ± Comparison against base commit 55efd4e.

@caalador caalador marked this pull request as ready for review October 28, 2024 10:46
Copy link
Member

@tltv tltv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of the token file after build-frontend would also mean one can't run the app in production mode directly by running Spring application class in IDE.
I don't see anything in documentation telling that it should be possible so therefore it should be OK. Running with maven/gradle or running the package directly still works as usual.

A test would be good however.

@caalador
Copy link
Contributor Author

The issue with the test is just that it should check that the file is missing after the JVM closes.
BuildFrontendUtilTest in flow-plugin-base contains lots of tests that the token file exists and that it updates the file contents correctly.

@mshabarov mshabarov merged commit b4b7e35 into main Oct 30, 2024
26 checks passed
@mshabarov mshabarov deleted the issues/20294 branch October 30, 2024 08:09
vaadin-bot pushed a commit that referenced this pull request Oct 30, 2024
Clean the token file after
production build/execution
to not make ide app execution
run app in production mode.

Closes #20294
vaadin-bot added a commit that referenced this pull request Oct 30, 2024
Clean the token file after
production build/execution
to not make ide app execution
run app in production mode.

Closes #20294

Co-authored-by: caalador <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production build breaks future development
4 participants