-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove tokenFile after production build #20346
Conversation
Clean the token file after production build/execution to not make ide app execution run app in production mode. Closes #20294
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of the token file after build-frontend would also mean one can't run the app in production mode directly by running Spring application class in IDE.
I don't see anything in documentation telling that it should be possible so therefore it should be OK. Running with maven/gradle or running the package directly still works as usual.
A test would be good however.
The issue with the test is just that it should check that the file is missing after the JVM closes. |
Clean the token file after production build/execution to not make ide app execution run app in production mode. Closes #20294
Clean the token file after production build/execution to not make ide app execution run app in production mode. Closes #20294 Co-authored-by: caalador <[email protected]>
This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version. |
Clean the token file after
production build/execution
to not make ide app execution
run app in production mode.
Closes #20294