fix: allow setting flex-grow to 0 through FlexComponent #7176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
changed the title
|
sissbruecker
approved these changes
Mar 10, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
* bug: FlexComponent setFlexGrow to 0 sets the style attribute instead of removing it * add regression test --------- Co-authored-by: Sascha Ißbrücker <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
* bug: FlexComponent setFlexGrow to 0 sets the style attribute instead of removing it * add regression test --------- Co-authored-by: Sascha Ißbrücker <[email protected]>
sissbruecker
added a commit
that referenced
this pull request
Mar 10, 2025
* bug: FlexComponent setFlexGrow to 0 sets the style attribute instead of removing it * add regression test --------- Co-authored-by: MikeV2000 <[email protected]> Co-authored-by: Sascha Ißbrücker <[email protected]>
sissbruecker
added a commit
that referenced
this pull request
Mar 10, 2025
* bug: FlexComponent setFlexGrow to 0 sets the style attribute instead of removing it * add regression test --------- Co-authored-by: MikeV2000 <[email protected]> Co-authored-by: Sascha Ißbrücker <[email protected]>
|
This ticket/PR has been released with Vaadin 24.8.0.alpha2 and is also targeting the upcoming stable 24.8.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in the issue below the setFlexGrow method in FlexComponent removes the flex-grow attribute if 0 is passed in. The expected behavior is that it is set to 0.
Fixes #1244 (issue)
Type of change
Checklist
Additional for
Featuretype of change