-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Gantt specific API to Charts #6997
Conversation
This reverts commit e57591e.
@DiegoCardoso is there a way how to get around th SonarCloud Code Analysis? It's bragging about the code duplication (even in the existing Chart files) - but to be honest the Chart API is full of duplication and I really don't feel like I should fix that in scope of this task |
There are some battles we can't really win. I think we can ignore them. The SonarCloud Code Analysis is not a required check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments to the PR.
...w-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/model/Marker.java
Outdated
Show resolved
Hide resolved
...ow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/model/XAxis.java
Outdated
Show resolved
Hide resolved
...ow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/model/YAxis.java
Outdated
Show resolved
Hide resolved
.../vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/model/PathfinderType.java
Outdated
Show resolved
Hide resolved
…/vaadin/flow/component/charts/model/PathfinderType.java Co-authored-by: Diego Cardoso <[email protected]>
...aadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/model/PlotOptionsGantt.java
Show resolved
Hide resolved
|
This ticket/PR has been released with Vaadin 24.7.0.alpha5 and is also targeting the upcoming stable 24.7.0 version. |
Description
This change brings support for Gantt specific API to Vaadin Charts.
A new
ChartType
has been introduced to be able to activate Gantt chart feature.Also, after discussion with Diego and Rolf we:
timeline
property invalid - in the web component the value oftimeline
is ignored when chart is Gantt chart, in the Java api we throw IllegalArgumentException when somebody tries to use the Gantt chart and activate timeline at the same time.New classes or attributes were added to cover the Highcharts 9.2.2 Gantt Chart API. Changes to existing API classes reflect probably the changes between earlier versions of Highcharts and the currently supported 9.2.2. In any case, if change to existing class was made, I made sure it's valid also for other Highcharts charts.
I've added as many properties as I could, hopefully not missing anything - with the exception of "drag and drop" support (
series.gantt.dragDrop
)... however, that is not supported anywhere in the Vaadin Charts API.I've added a lot of Demos in form of Integration tests to verify that the changes in the API work.
Fixes #4731
Type of change
Checklist
Additional for
Feature
type of change