fix: Correctly render CalendarDatePicker on iOS
#19662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform/macos 🍏
|
@Mergifyio backport release/stable/5.6 |
✅ Backports have been created
|
jeromelaban
approved these changes
Mar 10, 2025
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19662/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19662/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19662/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19662/index.html |
agneszitte
reviewed
Mar 10, 2025
There was a problem hiding this comment.
@MartinZikmund is it possible to add documentation details for CalendarDatePicker as well with this PR please so it is not forgotten and to make things clearer (mentioning that CalendarDatePicker is managed only, compared to the current doc for DatePicker where DatePicker is native by default (but can be managed if user sets feature flag)).
We don't have CalendarDatePicker in the docs menu compared to DatePicker.
|
The build 157308 found UI Test snapshots differences: Details
|
6 tasks
jeromelaban
added a commit
that referenced
this pull request
Mar 11, 2025
…5.6/pr-19662 fix: Correctly render `CalendarDatePicker` on iOS (backport #19662)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #19505
PR Type
What kind of change does this PR introduce?
What is the current behavior?
NRE in
BorderLayerRendererWhat is the new behavior?
No NRE
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.