Fix time varying J and tcl injection in Xf_ThermSpinXferEvolver

[swapneelap]

No description provided.

[lang-m]

Is any of the tests actually running a simulation with time-varying Xf_ThermSpinXferEvolver? If not, we should add a test to micromagnetictests.

[swapneelap]

Is any of the tests actually running a simulation with time-varying Xf_ThermSpinXferEvolver? If not, we should add a test to micromagnetictests.

Yes absolutely! I will add tests. I am also thinking it would be good to reorder a few things in oc.script when it comes to simulations at finite temperature. For example, it is redundant to to ask user for an evolver if both mm.Slonczewski and system.T are defined since oc.Xf_ThermSpinXferEvolver is the only suitable option (?).

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a8efd2c) 93.45% compared to head (581a22f) 93.45%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files          26       26           
  Lines        1177     1177           
=======================================
  Hits         1100     1100           
  Misses         77       77           

Impacted Files	Coverage Δ
oommfc/scripts/evolver.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[swapneelap]

@lang-m if this is good for now, should we close this? There relevant test is here.

[lang-m]

@swapneelap Have you created an issue to remind us to rework the tests and get access to mif string? Once that is done, you can merge.

[swapneelap]

@swapneelap Have you created an issue to remind us to rework the tests and get access to mif string? Once that is done, you can merge.

Done!