WIP: simplify fill implementation #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
commented
Sep 11, 2019
|
|
||
| @Benchmark | ||
| def fill100(): String = | ||
| Doc.fill(Doc.text(","), strs.map(Doc.text)).render(100) | ||
| Doc.fill(Doc.line, strs.map(Doc.text)).render(100) |
There was a problem hiding this comment.
not using line here is kind of a worst case. The original fill didn't even have this arg, it always used line.
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 4 4
Lines 274 274
Branches 19 19
=======================================
Hits 266 266
Misses 8 8Continue to review full report at Codecov.
|
|
this was folded into #181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fill is one of the main combinators that is complicated by having a hardLine for two reasons:
It occurs to me, we could greatly simplify using defer and it is only a bit slower:
so the simpler implementation is about 75% as fast.
One problem with this implementation is that if the separator does not have line in it we are in a very bad case, but if you don't have a line in the fill sep, then you have an exponentially bad time searching for a fit.
cc @seanmcl