clean: remove extraneous alwaysStrict setting #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- alwaysStrict will be turned on if strict is turned on - per the TypeScript Website (related to a PR I once made to it) - afaik the rest are indeed additional settings and not set by strict - only changed strictest and ones generated from it
|
Cool, sounds good to me - thanks for the links 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
alwaysStrictwill be turned on whenstrictis on, so no need to set it againstrictmicrosoft/TypeScript-Website#500, fix: ensure strict checks are all recommended and related to microsoft/TypeScript-Website#971Details
only changed
strictest.jsonand the two other configs generated from/combined with itafaik the rest of the settings are indeed additional and not set by
strict