Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number or numeric? #92

Closed
Amorymeltzer opened this issue Sep 23, 2015 · 2 comments
Closed

Number or numeric? #92

Amorymeltzer opened this issue Sep 23, 2015 · 2 comments

Comments

@Amorymeltzer
Copy link

Of the five provided alternative sorts, tablesort.numeric.js is the only one whose filename (numeric) doesn't match the Tablesort.extend function (number). This could be confusing! I'd suggest picking one or the other; this'd be a PR but I figured you might have a preference as to which.
@xPaw xPaw closed this as completed in 8268fca Sep 24, 2015
@xPaw
Copy link
Contributor

xPaw commented Sep 24, 2015

Good point, fixed!

@Amorymeltzer
Copy link
Author

👍

Amorymeltzer added a commit to Amorymeltzer/mls that referenced this issue Sep 24, 2015
@Amorymeltzer
Rename tablesort.numeric.js to tablesort.number.js
8b9518b 
tristen/tablesort#92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amorymeltzer @xPaw