Simplify signing, enable notarization #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsusanka
approved these changes
Sep 7, 2022
I have simplified signing and enabled notarization in docker with rcodesign (a Rust-based tool, fully open-source; but it does connect to Apple servers for notarization). This tool enables notarization and signing fully in Docker on any OS, so it should work in CLI too. There is some prep-work that needs to be done on Mac OS side and on Apple website; but after that, the signing and notarization works automatically. It's not directly relevant to this commit, but I think you can also use it on Trezor Suite; a cursory glance there tells me that Trezor Suit is using electron-notarize, which needs to be run on Mac OS; rcodesign does not need that. Note that we need to use ldflags -s because of this issue of rcodesign https://github.com/indygreg/PyOxidizer/issues/636
igor-hnizdo
force-pushed
the
fix_sign_and_notarization
branch
from
da28494 to
7bf4b21
Compare
tsusanka
approved these changes
Sep 7, 2022
|
Moving the following work into #260. Thanks! |
|
cc @matejkriz, @mroz22 and @vdovhanych for this part:
We probably do not need to change that in Suite as it works fine but it is good to know, in case we would have some problems with the current solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have simplified signing and enabled notarization in docker with rcodesign (a Rust-based tool, fully open-source; but it does connect to Apple servers for notarization).
This tool enables notarization and signing fully in Docker on any OS, so it should work in CLI too.
There is some prep-work that needs to be done on Mac OS side and on Apple website; but after that, the signing and notarization works automatically.
It's not directly relevant to this commit, but I think you can also use it on Trezor Suite; a cursory glance there tells me that Trezor Suit is using electron-notarize, which needs to be run on Mac OS; rcodesign does not need that.
Note that we need to use ldflags -s because of this issue of rcodesign - indygreg/apple-platform-rs#17