検索履歴の追加 #2202
Merged
検索履歴の追加 #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2202 +/- ##
==========================================
+ Coverage 41.01% 41.08% +0.06%
==========================================
Files 148 148
Lines 3757 3763 +6
Branches 587 599 +12
==========================================
+ Hits 1541 1546 +5
- Misses 2214 2215 +1
Partials 2 2
Continue to review full report at Codecov.
|
sapphi-red
reviewed
May 22, 2021
Closed
- todo 削除したときは`store.currentInput`に追加されないでほしい
sapphi-red
reviewed
May 26, 2021
| :class="$style.icon" | ||
| :size="24" | ||
| :inner-size="12" | ||
| @click.stop="removeHistorySuggestion(label)" |
There was a problem hiding this comment.
ここで消すのではなくて、親にremoveイベント送って親で消してほしいです 🙏
これは選択のほうもそういう実装になってるので一貫性を保ちたいからです
src/components/Main/CommandPalette/SearchSuggestionHistoryItem.vue
Outdated
Show resolved
Hide resolved
src/components/Main/CommandPalette/SearchSuggestionHistoryItem.vue
Outdated
Show resolved
Hide resolved
….vue Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
- 一部変数名変更
….vue Co-authored-by: 翠 / green <[email protected]>
….vue Co-authored-by: 翠 / green <[email protected]>
|
修正しました |
sapphi-red
suggested changes
May 27, 2021
src/components/Main/CommandPalette/SearchSuggestionHistoryItem.vue
Outdated
Show resolved
Hide resolved
….vue Co-authored-by: 翠 / green <[email protected]>
|
直しました:pray: |
sapphi-red
reviewed
May 28, 2021
src/components/Main/CommandPalette/SearchSuggestionHistoryItem.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
履歴が表示されるところまでは作りましたが、履歴が更新されません。