Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): when createFunnelSteps extends with no option at initial the context assigned never type. #53

Merged
merged 2 commits into from
Sep 8, 2024
Merged

fix(core): when createFunnelSteps extends with no option at initial the context assigned never type. #53

merged 2 commits into from
Sep 8, 2024

Conversation

minuukang
Copy link
Member

@minuukang minuukang commented Sep 8, 2024 •
edited
Loading

close #52

This issue is side effect from #49 . Fix TPrevFunnelStepOption generic type default assigned FunnelStepGuardOption

  • Remove FunnelStepBuilder using with meta type (it should be verbose type hint by using requiredKeys option. meta option should be came back with new interface..)
  • rename FunnelStepBuilder => SimpleFunnelStepBuilder
  • add test case of current issue.

@minuukang minuukang self-assigned this Sep 8, 2024
@minuukang minuukang merged commit d2e642e into main Sep 8, 2024
1 check was pending
@minuukang
Copy link
Member Author

Thank you @XionWCFM !!

@minuukang minuukang deleted the ISSUE-52 branch September 8, 2024 08:06
@github-actions github-actions bot mentioned this pull request Sep 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunYoungKwon SunYoungKwon Awaiting requested review from SunYoungKwon SunYoungKwon is a code owner

Assignees

@minuukang minuukang

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@minuukang