Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding effone's code changes #12

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

andrewjs18
Copy link

No description provided.

@effone
Copy link

effone commented Jul 13, 2018

Note:

  1. Thats a huge change and little much for a PR I guess.
  2. There are still 2 known bugs that I have yet to fix in the plugin.
  3. The version number remained unchanged, which, as a PR should be bumped.

@Eldenroot
Copy link
Contributor

Great and useful improvements, anyway I have found these bugs:

  1. when you disallow remote avatars in ACP -> last avatar plugin is not working -> all avatars in latest post are replaced by a "default avatar" set in ACP (even for local avatars uploaded by users, not the remote ones)

  2. there are "annoying" php errors messages above the content (in the header), it cam be solve by adding @ before file_get_content in .php file as @effone advised me :)

I have one idea for improvement - make a better description for level of compression for avatars in ACP, it is not clear at the first sight.

I am looking forward to test any beta version with fixed issues above :) thank you guys for your work and contribution!!!

@Eldenroot
Copy link
Contributor

There is a new PR with one bug fix :)

#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants