Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surge的rule转换为Clash的rule时内联注释未过滤 #285

Closed
Emphasia opened this issue Dec 20, 2020 · 0 comments
Closed

Surge的rule转换为Clash的rule时内联注释未过滤 #285

Emphasia opened this issue Dec 20, 2020 · 0 comments

Comments

@Emphasia
Copy link

调用/sub?target=clash&new_name=true&config=*/config.ini时，

当config.ini中含有：

surge_ruleset=直连,https://raw.githubusercontent.com/DivineEngine/Profiles/master/Surge/Ruleset/Unbreak.list

即：

# > Google
DOMAIN-SUFFIX,blog.google // Google Blog
DOMAIN-SUFFIX,googletraveladservices.com // Google Flights

转换结果会包含：

 - DOMAIN-SUFFIX,blog.google // Google Blog,直连
 - DOMAIN-SUFFIX,googletraveladservices.com // Google Flights,直连

https://manual.nssurge.com/overview/configuration.html
Comment
Surge configuration file supports comment line, starts with '#', ';' and '//'. Comment inline will also be supported with separation of '//'. The comments for rules and hosts will be kept if editing the configuration with GUI, and the other comments will be deleted after saving.

// 好像应该是Surge的rule的注释？但是在转换输出为Clash的rule时却没有过滤掉..
Emphasia added a commit to Emphasia/subconverter that referenced this issue Dec 22, 2020
@Emphasia
fix inline comment of ruleset not removed (tindy2013#285)
a939d01
tindy2013 added a commit that referenced this issue Mar 23, 2021
@tindy2013
Complete refactor of project file structure
3d67406 
Fix incorrect handing of default node parameters in SSD subscription.
Fix unable to parse some Clash rule-providers (#289).
Fix not filtering inline comments in some Surge rulesets. (#285)
Add Cron task options.
Add clean context option for persisting a JS context across the whole request.
Replace JS engine with QuickJS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Emphasia @tindy2013