Adds Date and Time, update render.

[theimpossibleleap]

Hello! This was closed for being stale? Just want to get it merged with the updates. Thank you!

[tidbyt]

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

• Sign the CLA if you haven't already
• Ensure your build is green! Any problem will display a proposed solution to try out
• Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

	Test	Details
✅	App Dir	All files are in a single app directory
🟡	Modules	Usage of http.star requires review
✅	Original Author	The original author matches the PR author

[theimpossibleleap]

Not sure what to write to ensure this doesn't stay stale and close again. Hopefully this gets approved and merged soon!

Thank you!

[theimpossibleleap]

Hello @matslina - I see that PRs are continuing to close for being stale, even though they are waiting to merge. Is there a way to keep a PR from going stale? Any help is appreciated.

[theimpossibleleap]

Hey @drudge - what does the Waiting on Author tag mean? It shows me that it's ready to merge it's just waiting for the review due to the http.star usage.

[theimpossibleleap]

Hey @drudge - I updated branch. Can this be successfully merged? Thank you.

[theimpossibleleap]

@drudge @matslina Hey y'all, can I get a status update on this? Any help is appreciated.

[danielsitnik]

@theimpossibleleap is there a reason why you're always converting the date/time to US/Pacific instead of the device's timezone?

You can get the device's timezone by reading the $tz configuration with the code below:

DEFAULT_TIMEZONE = "US/Pacific"

def main(config):
  device_tz = config.get("$tz", DEFAULT_TIMEZONE)

[theimpossibleleap]

@theimpossibleleap is there a reason why you're always converting the date/time to US/Pacific instead of the device's timezone?

You can get the device's timezone by reading the $tz configuration with the code below:

DEFAULT_TIMEZONE = "US/Pacific"

def main(config):
  device_tz = config.get("$tz", DEFAULT_TIMEZONE)

Hey @danielsitnik!

No particular reason! Since it's a West Coast / Pacific NHL team and I, selfishly, built the app for myself, I just made it Pacific. I can definitely add $tz, I didn't know this existed for the Tidbyt. Thank you!

Adam

[danielsitnik]

@theimpossibleleap no worries, this "feature" was never documented anyway.
You had to learn it by looking at the other apps in the repo. 😁

If you could please make this small improvement, this would make the app usable by more users and more in line with the other apps that handle date/time this way. Then I'll gladly approve the PR!

[theimpossibleleap]

Hey @danielsitnik - I made the suggested update! Let me know if it is correct. I appreciate you!