Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecurityPkg/AuthVariableLib: Fix memory leak in CheckSignatureListFormat #10888

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SecurityPkg/AuthVariableLib: Fix memory leak in CheckSignatureListFormat #10888

wants to merge 2 commits into from

Conversation

baranee
Copy link
Contributor

@baranee baranee commented Mar 24, 2025 •
edited
Loading

Description

RsaGetPublicKeyFromX509 allocates memory for RsaContext parameter and the memory allocated earlier is not necessary

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Verified basic secure boot keys are enrolled which goes thru CheckSignatureListFormat

Integration Instructions

N/A

@baranee
SecurityPkg/AuthVariableLib: Fix memory leak in CheckSignatureListFormat
d9547f4 
RsaGetPublicKeyFromX509  allocates memory for RsaContext parameter
and the memory allocated earlier is not necessary

Signed-off-by: Anbazhagan Baraneedharan <[email protected]>
@baranee baranee marked this pull request as ready for review March 24, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyao1 jyao1 Awaiting requested review from jyao1

@mxu9 mxu9 Awaiting requested review from mxu9

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@baranee