Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.1 fails to generate requirements from poetry lockfile #193

Closed
ghost opened this issue Sep 28, 2021 · 4 comments
Closed

v1.1.1 fails to generate requirements from poetry lockfile #193

ghost opened this issue Sep 28, 2021 · 4 comments
Assignees
Labels
human_intervention_required kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ghost
Copy link

ghost commented Sep 28, 2021

Describe the bug

micropipenv fails to generate requirements using poetry method for certain configurations in 1.1.1

To Reproduce

given:

[tool.poetry]
name = "test"
version = "0.1.0"
description = "test"
authors = ["test"]

[tool.poetry.dependencies]
python = "3.8.10"
flask-restx = "^0.4"
webargs = "^7.0"
gunicorn = "^19.9"
Flask-PyMongo = "^2.3.0"
py-healthcheck = "^1.2"
invoke = "^1.6"
pyyaml = "^5.4"

[tool.poetry.dev-dependencies]
pytest = "*"
pytest-mock = "*"
pytest-flask = "*"
requests = "*"
requests-mock = "*"
responses = "*"

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

when I generate the poetry lockfile using poetry lock on poetry version 1.1.10

when I execute micropipenv requirements --method poetry --no-dev

I get
'atomicwrites'
and then exit code 3

when I execute micropipenv requirements --method poetry --no-default

I get
local variable 'category' referenced before assignment

Expected behavior

On micropipenv 1.1.0, the requirements files are generated as expected

@goern
Copy link
Member

goern commented Oct 4, 2021

/kind bug
/priority important-soon
/assign @fridex
/triage accepted

@sesheta sesheta added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 4, 2021
@sesheta sesheta added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Oct 4, 2021
@frenzymadness
Copy link
Collaborator

Thanks for the report. I'm gonna investigate it.

@frenzymadness
Copy link
Collaborator

Could you please test my fix in #195?

frenzymadness added a commit to frenzymadness/micropipenv that referenced this issue Oct 4, 2021
frenzymadness added a commit to frenzymadness/micropipenv that referenced this issue Oct 4, 2021
@goern
Copy link
Member

goern commented Oct 4, 2021

/unassign @fridex
/assign @frenzymadness
/lifecycle active

@sesheta sesheta assigned frenzymadness and unassigned fridex Oct 4, 2021
@sesheta sesheta added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 4, 2021
@sesheta sesheta closed this as completed in 1521d06 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
human_intervention_required kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants