cleanup of codes and docs #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thofma
reviewed
Mar 9, 2022
|
Thanks. This looks good! |
|
Great. I have seen other typos I will have to correct. However, I don't understand that the tests fail: while running the |
|
The tests are run with |
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
==========================================
- Coverage 70.34% 70.27% -0.08%
==========================================
Files 314 314
Lines 92353 92337 -16
==========================================
- Hits 64967 64889 -78
- Misses 27386 27448 +62
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to end the improvement of the test coverage for hermitian spaces/lattices and do a little preparation for the html documentation (c.f. #557 ).
I have done some cleanups on some codes in the
~/QuadForm/Herm/repository, and I started to develop more the documentation and making it more consistent. I focused mainly on what I want to treat in the html documentation at first (i.e. hermitian spaces/lattices) so the changes are mostly regarding functions about hermitian world. Nonetheless, I have modified also few things in~/QuadForm/and~/QuadForm/Quad/where I have found something to change.There is a final test for genus representatives of hermitian lattices supposed to catch a some part of the code not covered previously.
I am not strict on the documentation, I have tried to do as precised and clear possible but this can still be modified, of course.