Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MaximalOrder -> maximal_order, Order -> order #1832

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

thofma
Copy link
Owner

@thofma thofma commented Apr 1, 2025

It was time

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 72.29730% with 41 lines in your changes missing coverage. Please review.

Project coverage is 76.56%. Comparing base (bf42d1f) to head (5fbc735).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/NumFieldOrd/NfOrd/Overorders.jl 52.94% 8 Missing ⚠️
src/NumFieldOrd/NfOrd/NfOrd.jl 72.72% 6 Missing ⚠️
src/NumFieldOrd/NfRelOrd/NfRelOrd.jl 80.95% 4 Missing ⚠️
src/AlgAssAbsOrd/Order.jl 85.00% 3 Missing ⚠️
src/FunField/IntClsZx.jl 25.00% 3 Missing ⚠️
src/AlgAss/AlgGrp.jl 0.00% 2 Missing ⚠️
src/AlgAssAbsOrd/PIP/maximal.jl 33.33% 2 Missing ⚠️
src/NumFieldOrd/NfOrd/Clgp/Ctx.jl 0.00% 2 Missing ⚠️
src/AlgAssAbsOrd/PIP/bley_hofmann_johnston.jl 66.66% 1 Missing ⚠️
src/AlgAssAbsOrd/PIP/bley_johnston.jl 50.00% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1832      +/-   ##
==========================================
- Coverage   76.57%   76.56%   -0.02%     
==========================================
  Files         362      362              
  Lines      115011   115012       +1     
==========================================
- Hits        88071    88059      -12     
- Misses      26940    26953      +13     
Files with missing lines Coverage Δ
ext/GAPExt/abelian_layer.jl 91.22% <100.00%> (ø)
src/AlgAss/Map.jl 79.61% <100.00%> (ø)
src/AlgAss/Ramification.jl 100.00% <100.00%> (ø)
src/AlgAssAbsOrd/Conjugacy/Conjugacy.jl 98.32% <100.00%> (ø)
src/AlgAssAbsOrd/Conjugacy/Husert.jl 91.30% <100.00%> (ø)
src/AlgAssAbsOrd/FakeAbsOrdQuoRing.jl 94.59% <100.00%> (ø)
src/AlgAssAbsOrd/Ideal.jl 77.25% <100.00%> (+0.08%) ⬆️
src/AlgAssAbsOrd/LocallyFreeClassGroup.jl 92.47% <ø> (ø)
src/AlgAssAbsOrd/Quotient.jl 100.00% <100.00%> (ø)
src/AlgAssRelOrd/Ideal.jl 73.12% <100.00%> (ø)
... and 36 more

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thofma thofma merged commit b57a32d into master Apr 1, 2025
18 checks passed
@thofma thofma deleted the th/ooo branch April 1, 2025 19:38
@thofma thofma changed the title chore: MaximalOrder -> maximal_order, Order -> order Deprecate MaximalOrder -> maximal_order, Order -> order Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants