Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connecting to incorrect container #53

Closed
mikeforkin opened this issue Oct 14, 2024 · 5 comments · Fixed by #55
Closed

Connecting to incorrect container #53

mikeforkin opened this issue Oct 14, 2024 · 5 comments · Fixed by #55

Comments

@mikeforkin
Copy link
Contributor

I've just downloaded 0.6.0 and I'm trying to connect to a container, however, it is connecting to a different container than the one I selected. I've tried to debug locally, but I cannot replicate the issue as any local builds work just fine.

I am on an intel mac running Ventura 13.6.7.
@mikeforkin
Copy link
Contributor Author

If it helps at all, it is always picking the same container (the last one in the list) to log into rather than the one that I selected.

@tedsmitt
Copy link
Owner

Thanks for raising @mikeforkin, I'll try and find some time to look into this tomorrow.

tedsmitt added a commit that referenced this issue Oct 15, 2024
@tedsmitt
fix(app): #53 fix pointer issue which was overwriting tasks in map
cc67ed9
@tedsmitt tedsmitt mentioned this issue Oct 15, 2024
Merged
@tedsmitt tedsmitt linked a pull request Oct 15, 2024 that will close this issue
Closes #53 - incorrect container selection #55
Merged
tedsmitt added a commit that referenced this issue Oct 15, 2024
@tedsmitt
Closes #53 - incorrect container selection (#55)
c77b207 
* fix(app): #53 fix pointer issue which was overwriting tasks in map

* chore(opts): remove unecessary enable-env param now that we can configure using env vars

* chore(workflow): fix goreleaser build with skip publish arg
@tedsmitt
Copy link
Owner

tedsmitt commented Oct 15, 2024 •
edited
Loading

@mikeforkin Thanks for reporting this, that was a pretty gnarly bug! Fixed in v0.6.1

EDIT: I've fixed the Task selection but not the container selection! d'oh! I will re-release v0.6.1 shortly

@tedsmitt tedsmitt reopened this Oct 15, 2024
@tedsmitt
Copy link
Owner

Re-released v0.6.1

@mikeforkin
Copy link
Contributor Author

@mikeforkin Thanks for reporting this, that was a pretty gnarly bug! Fixed in v0.6.1

EDIT: I've fixed the Task selection but not the container selection! d'oh! I will re-release v0.6.1 shortly

Awesome, thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #53 - incorrect container selection tedsmitt/ecsgo
2 participants
@tedsmitt @mikeforkin