Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade AWS SDK to v2 #49

Closed
tedsmitt opened this issue Oct 9, 2024 · 0 comments · Fixed by #50
Closed

Upgrade AWS SDK to v2 #49

tedsmitt opened this issue Oct 9, 2024 · 0 comments · Fixed by #50

Comments

@tedsmitt
Copy link
Owner

tedsmitt commented Oct 9, 2024 •
edited
Loading

As per https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/ the AWS Go SDK in use by this project should be updated to v2.

#45 is already open that implements this
@tedsmitt tedsmitt linked a pull request Oct 10, 2024 that will close this issue
Closes #49 - Upgrade to AWS SDK v2 #50
Merged
tedsmitt added a commit that referenced this issue Oct 10, 2024
@tedsmitt @tbobm
Closes #49 - Upgrade to AWS SDK v2 (#50)
7260d05 
* feat: upgrade AWS SDK to v2

Signed-off-by: Theo Bob Massard <[email protected]>

* tests: adapt tests to SDK v2

Signed-off-by: Theo Bob Massard <[email protected]>

* feat: add ECSClient interface and replace usage of concrete ecs.Client type in App

* tests: update tests to use ECSClient interface and update mocks

* feat: create EC2Client interface

* tests: fix remaining tests

* feat: swap use of ecs.client for ECSClient in getContainerPort

---------

Signed-off-by: Theo Bob Massard <[email protected]>
Co-authored-by: Theo Bob Massard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #49 - Upgrade to AWS SDK v2 tedsmitt/ecsgo
1 participant
@tedsmitt