Initial migration to NextJS #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technoph1le
requested review from
psychlone77,
saminjay and
Mathys-Gasnier
as code owners
package.json
Outdated
| "prismjs": "^1.29.0", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
| "react-router-dom": "^7.1.1", | ||
| "react-syntax-highlighter": "^15.6.1" | ||
| "react-syntax-highlighter": "^5.8.0" |
There was a problem hiding this comment.
why did we rollback the react syntax highlighter version ?
There was a problem hiding this comment.
Interesting. It was done with npm audit fix. I guess, it was meant to be 15.8.0, but that is weird 🤔
There was a problem hiding this comment.
There is a reported vulnerability in the latest prismjs package version GHSA-x7hr-w5r2-h6wg. The npm audit fix sometimes recommends downgrading to avoid the vulnerability. I would recommend to keep the packages on their latest versions until a patch for prismjs is released.
Not removing anything. Just importing all back one by one. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are migrating to NextJS before implementing the authentication and database storage system for each users. It will help us in the long term as QuickSnip starts to evolve.
Type of Change
Checklist
This is the initial draft, we will be making a lot of changes here. And, initial commit can have quite some errors until we fully and successfully migrate.
Related Issues
Closes #
Additional Context
Used this resource as a guide for migration from React Vite to NextJS: https://nextjs.org/docs/app/building-your-application/upgrading/from-vite
Screenshots (Optional)
Click to view screenshots