Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add percentage & speed, remove elasped time #62

Merged
merged 2 commits into from
Mar 29, 2025

Conversation

Integral-Tech
Copy link
Contributor

Fixes issue #3

@Integral-Tech Integral-Tech changed the title Addd percentage & speed, remove elasped time Add percentage & speed, remove elasped time Nov 27, 2024
@tarka
Copy link
Owner

tarka commented Dec 8, 2024

ack. I'm on the road ATM, I'll take a look when I get back.

@Integral-Tech
Copy link
Contributor Author

@tarka Would you like to review and approve my PR?

@tarka
Copy link
Owner

tarka commented Feb 15, 2025

Thanks for the PR. I've played with the new progress bar on various sized terminals and my main concern is that on a standard 80-char term the progress bar gets pushed down to a few characters:

Screenshot from 2025-02-15 11-15-41

It might be better to add a switch (e.g. --progress-type=[bar/mixed/detail]) to allow different styles of progress indicators. Would you be happy to add this to the PR?

@Integral-Tech
Copy link
Contributor Author

Integral-Tech commented Mar 6, 2025

@tarka I need to confirm what each option in --progress-type=[bar/mixed/detail] means :)

@tarka
Copy link
Owner

tarka commented Mar 28, 2025

Sorry @Integral-Tech, I totally missed your message.

My thought was that bar would be the current format, mixed would be your patch (minimal bar, more focused on details), and detail would be numbers only, no bar. Thoughts?

@Integral-Tech
Copy link
Contributor Author

Integral-Tech commented Mar 28, 2025

@tarka IMO maybe it is a good idea to show the numbers on a new line on narrow terminal windows

@tarka
Copy link
Owner

tarka commented Mar 28, 2025

Yeah, that's a good option.

@Integral-Tech
Copy link
Contributor Author

Integral-Tech commented Mar 28, 2025

@tarka With auto detection of terminal width, --progress-type switch seems to be unnecessary

@Integral-Tech
Copy link
Contributor Author

@tarka Done :)

Copy link
Owner

@tarka tarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll release shortly.

@tarka tarka merged commit 9ab42f3 into tarka:master Mar 29, 2025
@Integral-Tech Integral-Tech deleted the add-speed branch March 29, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants