-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add percentage & speed, remove elasped time #62
Conversation
0f058c6
to
faf6fc5
Compare
ack. I'm on the road ATM, I'll take a look when I get back. |
@tarka Would you like to review and approve my PR? |
Thanks for the PR. I've played with the new progress bar on various sized terminals and my main concern is that on a standard 80-char term the progress bar gets pushed down to a few characters: It might be better to add a switch (e.g. |
@tarka I need to confirm what each option in |
Sorry @Integral-Tech, I totally missed your message. My thought was that |
@tarka IMO maybe it is a good idea to show the numbers on a new line on narrow terminal windows |
Yeah, that's a good option. |
@tarka With auto detection of terminal width, |
faf6fc5
to
0c2d746
Compare
@tarka Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll release shortly.
Fixes issue #3