Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

Ignore inline HTML in table cells #310

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Ignore inline HTML in table cells #310

merged 1 commit into from
Dec 14, 2024

Conversation

pengjiz
Copy link
Contributor

@pengjiz pengjiz commented Dec 14, 2024

Instead of panicking, currently mdcat ignores inline elements in a table cell. InlineHtml was left out unanticipatedly, so this commit adds it.

Re: #306 (@suvayu Could you check if this fixes the crash you encountered?)

@swsnr swsnr self-assigned this Dec 14, 2024
Copy link
Owner

@swsnr swsnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pengjiz Please update CHANGELOG.md.

@swsnr swsnr assigned pengjiz and unassigned swsnr Dec 14, 2024
@swsnr swsnr added the bug Something isn't working label Dec 14, 2024
This, instead of panicking, aligns with the behaviour for other inline
elements in a table cell.

Re: swsnr#301, swsnr#306
@pengjiz
Copy link
Contributor Author

pengjiz commented Dec 14, 2024 via email

@swsnr swsnr enabled auto-merge December 14, 2024 13:31
@swsnr swsnr merged commit 4efe132 into swsnr:main Dec 14, 2024
4 checks passed
@suvayu
Copy link

suvayu commented Dec 14, 2024

@pengjiz Thanks! This fixes the crash :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants