Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

Add support for ghostty terminal #300

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add support for ghostty terminal #300

merged 1 commit into from
Nov 12, 2024

Conversation

mattrobenolt
Copy link
Contributor

Fixes #299

@mattrobenolt
Copy link
Contributor Author

Sorta orthogonal to this, longer term if you care, the kitty graphics protocol can be detected with a query, which can eliminate the need to explicitly support certain terminals, and this list becoming a maintainer burden. I'm not advocating for implementing this, just an FYI if you were unaware this existed. That way any new terminals, whether closed source, whatever, that implement this protocol can utilize the feature automatically.

https://sw.kovidgoyal.net/kitty/graphics-protocol/#querying-support-and-available-transmission-mediums

Copy link
Owner

@swsnr swsnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙏

Thanks for updating README and the manual page 🙏

Could you also add a CHANGELOG entry as well?

@mattrobenolt
Copy link
Contributor Author

Could you also add a CHANGELOG entry as well?

Added.

@swsnr
Copy link
Owner

swsnr commented Nov 12, 2024

Sorta orthogonal to this, longer term if you care, the kitty graphics protocol can be detected with a query, which can eliminate the need to explicitly support certain terminals, and this list becoming a maintainer burden.

I'm aware but it'd be quite a bit of an refactoring to turn detection from the purely passive process it is now to an active process, and it'd complicate things, as we'd have to deal with eg timeouts etc.

So far it hasn't been worth the effort 🤷

@swsnr swsnr enabled auto-merge November 12, 2024 20:04
@swsnr swsnr merged commit 01a75db into swsnr:main Nov 12, 2024
5 checks passed
@mattrobenolt mattrobenolt deleted the ghostty branch November 12, 2024 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for images in Ghostty
2 participants