This repository was archived by the owner on Jan 10, 2025. It is now read-only.
Make SVG support optional in library #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
swsnr
commented
Apr 14, 2023
swsnr
commented
- Move svg to resources module
- Refactor inline image writing
- Guard SVG rendering behind SVG feature
Introduce an InlineImageProtocol trait which abstracts writing an inline image from a resource URL. Move all image related code into the corresponding implementations. This significantly reduces the dispatch code for inline images, and provides an isolated place where we can stub out image handling.
swsnr
force-pushed
the
optional-svg-support
branch
4 times, most recently
from
3f2750c to
313baab
Compare
swsnr
force-pushed
the
optional-svg-support
branch
4 times, most recently
from
e3b54e1 to
d21d44d
Compare
swsnr
force-pushed
the
optional-svg-support
branch
from
d21d44d to
26ad991
Compare
Use less jobs for Rust; only split up by target, and then run everything as steps inside the job. This means we have to mark much less workflows as required status checks, and have a much smaller actions view.
swsnr
force-pushed
the
optional-svg-support
branch
from
2a739e6 to
e80ff6c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.