This repository was archived by the owner on Jan 10, 2025. It is now read-only.
Expose resource handling in API #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a ResourceUrlHandler trait and require that API users pass an object of this trait to `push_tty`. Remove `ResourceAccess`; local only resource access is now implemented by simply creating a resource handler which only reads `file:` URLs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a ResourceUrlHandler trait and require that API users pass an
object of this trait to
push_tty.Remove
ResourceAccess; local only resource access is now implementedby simply creating a resource handler which only reads
file:URLs.