This repository was archived by the owner on Jan 10, 2025. It is now read-only.
automatically convert ioctl request parameter #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igalic I've hopefully fixed the clippy errors on main; would you mind to rebase this PR onto main? Sorry for the noise. |
FreeBSD ioctl(2) takes unsigned long long as request parameter. Here we automatically convert it with `.into()` to whatever the libc underneath needs This fixes swsnr#177
|
so, finally got to my laptop (the initial patch was created on my phone) |
|
failing as predicted. |
|
Sure. Just do add a comment about the reason (including a link to the issue). |
|
Merged with d44fd01 |
|
I released a new version with this fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD ioctl(2) takes unsigned long long as request parameter.
Here we automatically convert it with
.into()to whatever the libc underneath needsThis fixes #177