This repository was archived by the owner on Jan 10, 2025. It is now read-only.
Fix the image re-sizing in kitty #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swsnr
suggested changes
May 3, 2020
|
Thanks for fixing this; I'm sorry I introduced this blatant bug when refactoring. Would you mind to look into my comments, and rebase onto |
|
Oh, and please do add this change to |
|
I've rebased with the upstream/master and resolved the open issues. |
swsnr
force-pushed
the
master
branch
2 times, most recently
from
43ccc4e to
2317335
Compare
|
Hey. I've reworked the code and I hope you like it now. Let me know :-) |
swsnr
approved these changes
May 24, 2020
|
Thanks. Merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey.
Here a separate PR for fixing the re-sizing bug in kitty terminal. The resulting image size from the resize must be used otherwise the image cannot be rendered in kitty.
Fabian