This repository was archived by the owner on Jan 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 76
tab completion not working in zsh #214
Labels
bug
Something isn't working
Comments
I can't help you; I do not use zsh. I'm sorry but you need to debug and fix this yourself. Pull requests are welcome. |
swsnr
added a commit
that referenced
this issue
Nov 28, 2022
We used to generate completions for the top-level command, but that's not correct in a multicall binary: It includes the subcommands as completable arguments, whereas we actually need to split completions per subcommand. Hence, iterate over the two relevant subcommands aka binary names, and separately generate the completion for each corresponding subcommand. This corrects completions for mdcat, and as a bonus we now also generate completions for mdless which we didn't have before. Closes GH-214 [ci skip]
swsnr
added a commit
that referenced
this issue
Nov 28, 2022
We used to generate completions for the top-level command, but that's not correct in a multicall binary: It includes the subcommands as completable arguments, whereas we actually need to split completions per subcommand. Hence, iterate over the two relevant subcommands aka binary names, and separately generate the completion for each corresponding subcommand. This corrects completions for mdcat, and as a bonus we now also generate completions for mdless which we didn't have before. Closes GH-214
swsnr
added a commit
that referenced
this issue
Nov 28, 2022
We used to generate completions for the top-level command, but that's not correct in a multicall binary: It includes the subcommands as completable arguments, whereas we actually need to split completions per subcommand. Hence, iterate over the two relevant subcommands aka binary names, and separately generate the completion for each corresponding subcommand. This corrects completions for mdcat, and as a bonus we now also generate completions for mdless which we didn't have before. Closes GH-214
swsnr
added a commit
that referenced
this issue
Nov 28, 2022
We used to generate completions for the top-level command, but that's not correct in a multicall binary: It includes the subcommands as completable arguments, whereas we actually need to split completions per subcommand. Hence, iterate over the two relevant subcommands aka binary names, and separately generate the completion for each corresponding subcommand. This corrects completions for mdcat, and as a bonus we now also generate completions for mdless which we didn't have before. Closes GH-214
@meredrica I think I've found the issue, see #216 I'll make a new release with this fix soon; I'd appreciate testing 🙂 |
@meredrica 0.30.0 is out, with a change which hopefully fixes this issue. Let me know if you still have issues with completion. |
Hi! Will do asap and get back to you |
@swsnr can confirm, working now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
hi!
Tab completion for file names seems to be broken in zsh
steps:
then try to autocomplete the README.md
The text was updated successfully, but these errors were encountered: