Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Make inline_globals noop by default #10231

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 19, 2025

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Mar 19, 2025
@kdy1 kdy1 self-assigned this Mar 19, 2025
Copy link

changeset-bot bot commented Mar 19, 2025

⚠️ No Changeset found

Latest commit: 4f8e074

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Mar 19, 2025

CodSpeed Performance Report

Merging #10231 will degrade performances by 1.05%

Comparing kdy1/globals-default (4f8e074) with main (482b63a)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 150 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 2.8 µs 2.8 µs -1.05%
es/lints/libs/terser 29.7 ms 29.2 ms +1.95%

@kdy1 kdy1 marked this pull request as ready for review March 20, 2025 04:44
@kdy1 kdy1 requested review from a team as code owners March 20, 2025 04:44
@kdy1 kdy1 merged commit b192dc8 into main Mar 20, 2025
169 checks passed
@kdy1 kdy1 deleted the kdy1/globals-default branch March 20, 2025 04:44
kdy1 added a commit that referenced this pull request Mar 20, 2025
kdy1 added a commit that referenced this pull request Mar 20, 2025
@kdy1 kdy1 modified the milestones: Planned, v1.11.12 Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

inline_globals should be noop by default
1 participant