Add print block to phrase maker widget stack for lyric #4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@Commanderk3 You worked on this feature, so I think it's good to have your opinion too. |
|
Sure, I mean users will be aware of the lyrics feature so it's a good addition to the default stack. |
|
I have my doubts about this. But let's have @pikurasa chime in. And for sure, we should make sure this is well documented in the guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially to add lyrics in phrase maker we need to first manually add a print block to the phrase maker widget stack.
This PR adds a print block to the phrase maker widget stack by default.
Video:
print-block-in-phraseMaker.mp4
@walterbender What do you think?