Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PULL_REQUEST_TEMPLATE.md #52

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Create PULL_REQUEST_TEMPLATE.md #52

merged 3 commits into from
Oct 17, 2022

Conversation

hari-ajidesh
Copy link
Contributor

Closes #51

@hari-ajidesh
Copy link
Contributor Author

Please add the hacktoberfest-accepted label to this issue

@sudiptob2 sudiptob2 added the hacktoberfest-accepted hactoberfest2022 label Oct 17, 2022
@sudiptob2 sudiptob2 mentioned this pull request Oct 17, 2022
Closed
@sudiptob2
Copy link
Owner

Thanks for adding a lovely PR template. However, I actually want the template mentioned in the description of issue #52. Can you update 🙏

@hari-ajidesh
Updated PULL_REQUEST_TEMPLATE.md
a5ef04e 
As requested  in sudiptob2#51 , the PR template has been updated. Closes sudiptob2#51
@hari-ajidesh
Copy link
Contributor Author

PR template has been updated as requested in #51 . Do look into it

sudiptob2
sudiptob2 requested changes Oct 17, 2022
View reviewed changes
@sudiptob2 sudiptob2 marked this pull request as draft October 17, 2022 05:10
@hari-ajidesh hari-ajidesh marked this pull request as ready for review October 17, 2022 05:12
sudiptob2
sudiptob2 reviewed Oct 17, 2022
View reviewed changes
Copy link
Owner

@sudiptob2 sudiptob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please incorporate the change that I requested? I think heading 3 looks good than Heading 1

@hari-ajidesh
Updated PULL_REQUEST_TEMPLATE.md
7efd76c 
Updated based on the requested changes
@hari-ajidesh
Copy link
Contributor Author

Sorry for my mistake. I thought I incorporated them by clicking on "resolve conversation". Now they are updated

@sudiptob2 sudiptob2 marked this pull request as draft October 17, 2022 10:37
@sudiptob2 sudiptob2 marked this pull request as ready for review October 17, 2022 10:37
@sudiptob2 sudiptob2 merged commit 854db9b into sudiptob2:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudiptob2 sudiptob2 sudiptob2 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted hactoberfest2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a PR template
2 participants
@hari-ajidesh @sudiptob2