fix: momoize async retry state to prevent random updates #2627
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug Fix: Memoization Issue in
useAsyncRetry
HookProblem
The
useAsyncRetry
hook was returning a new object on every render, even though theAsyncState
or theretry
method doesn't change. This caused unnecessary re-renders in parent components, leading to performance issues.Fix
The returned value is now properly memoized to ensure it remains stable across renders unless its dependencies change.
Impact
useAsyncRetry
.useAsync
.Type of change
Checklist
yarn test
)yarn lint
). Fix it withyarn lint:fix
in case of failure.yarn lint:types
).