Add fail_with_status host function, fix #146 #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jonjove and @leighmcculloch I am posting this to make discussion concrete -- we shouldn't merge this until we have consensus that it's the right thing to do. |
leighmcculloch
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
👍🏻 Looks good to me.
Let's continue to discuss whether we should do this in https://github.com/stellar/stellar-xdr-next/issues/28.
| /// Causes the currently executing contract to fail immediately | ||
| /// with a provided status code, which must be of error-type | ||
| /// `ScStatusType::ContractError`. Does not actually return. | ||
| {"9", fn fail_with_status(status:Status) -> RawVal } |
There was a problem hiding this comment.
I'm wondering if fail is the best term for us to use. Maybe we should use abort_with_, since what will happen is equivalent to aborting? This isn't particularly important and it is fine, and maybe preferable, as is.
leighmcculloch
approved these changes
Sep 20, 2022
graydon
force-pushed
the
bug-146-fail-with-status
branch
from
9b68ab8 to
ec2575e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #146 by providing a fail_with_status function that users can call to fail the current contract call (trapping its vm) with a user-provided status. The status has to be the newly-added
ScStatusType::ContractErrorwith an opaque user-provided u32 body.