feat: updated all tab styles and add separate CSS / New UI Local providers #1393
Conversation
Stijnus
changed the title
|
Nice work @Stijnus, Testing this out asap. |
|
Looks awesome @Stijnus, Something i noticed before we merge this PR though is text foreground clashing with the background on these items. 
|
|
Hi @xKevIsDev , I will look at it this evening i think i know what is wrong with these items. |
|
I would vote against creating stylesheet for each components separately and create common classes along with unocss classes to mostly style the containers. |
|
@thecodacus makes a good point, best to keep the same pattern throughout the codebase. |
There was a problem hiding this comment.
no need for a proxy we already have a generic proxy endpoint for any url api.git-proxy.$.ts which basically should work for any endpoint just should rename it to just proxy maybe
| rules: { | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| }, | ||
| }, | ||
| { | ||
| files: [...tsFileExtensions, ...jsFileExtensions, '**/*.tsx'], |
There was a problem hiding this comment.
dont think we need these, it totally defeats the purpose of pre commit hooks validations
|
I really like what you have done here but I reaaally would love to see PR with smaller updates. if we can break it down to very focused change/atomic changes
like I said before it also helps the people to understand the changes by looking at the change log to see whats beed added here. 10k PR is a huge PR, and very difficult for others to review. Any PR more than 2k changes should be broken down to multiple PRs in my opinion |
|
WOAH wow |
Tab Navigation and Connection Interface Style Improvements
Overview
We've implemented a comprehensive styling system for the Settings tabs, with particular focus on the Connections tab and GitHub integration dialogs. The new styles replace Tailwind utility classes with semantic CSS classes, providing better maintainability, theme consistency, and improved user experience.
Tab Navigation Enhancements
Tab Management Structure
Tab Card Design
Tab Navigation Controls
.tab-buttonclass with consistent height and minimum widthConnections Tab Specific Improvements
Connection Cards
Form Elements
Action Buttons
GitHub Integration Dialog Improvements
Dialog Positioning and Layout
Repository Selection Experience
Theme Compatibility
--bolt-elements-background-depth-Xto correct--bolt-elements-bg-depth-XTechnical Implementation
CSS Architecture
tab-management.scssfor general tab structureconnections.scssfor the connections tabrepository-dialog.scssfor repository selectionpush-github-dialog.scssfor GitHub push dialogTheme Integration
These improvements provide a consistent, accessible, and visually appealing interface for users while maintaining the application's design language across both light and dark themes.