-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the SPA-like logic in the userland page and replace with proper routing #242
Comments
I made some good progress on this issue, have a more or less working proof of concept. A few notes for myself mostly: However with page routing, if one loads the page or uses goto or to go to a page, that information will not be preserved. Particularly if one say favouried a page. As compared to providing it as a part of the link: /children/feedback vs Idea: Easiest change is to use ID and pick it up from those new pages. Favourites will work, as will back buttons. What does this mean? Populate currentChild.id to keep the same logic for processing and loading the child data which we know works well. Right now I put the logic from pages directly into /folder/path/folder --> +page.svelte files. |
This sounds good to me, one minor thing while you're changing this: what about removing the |
I have done that with userLandingPage. I've actually kept userLand in my latest commits to use it for the logged-in-users-only sidebar config alongside routed pages, however, it could just as well be that the sidebar gets conditionally loaded on all pages |
componentStore
The text was updated successfully, but these errors were encountered: