This repository was archived by the owner on Sep 12, 2024. It is now read-only.
Undeploy jobs from hosts even if they are DOWN #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a host is down, we still want the `RollingUndeployPlanner` to attempt to undeploy from it, and then remove it from the list of removed hosts. Otherwise, the list of removed hosts for a deployment group can grow unboundedly.
|
@spotify/helios-team |
|
👍 but would prefer if we could add a test for this too |
mattnworb
approved these changes
Dec 12, 2016
davidxia
approved these changes
Dec 12, 2016
Current coverage is 51.35% (diff: 100%)@@ master #1039 diff @@
==========================================
Files 107 275 +168
Lines 5095 13065 +7970
Methods 0 0
Messages 0 0
Branches 858 1693 +835
==========================================
+ Hits 2363 6710 +4347
- Misses 2514 5852 +3338
- Partials 218 503 +285
|
rohansingh
pushed a commit
that referenced
this pull request
Dec 13, 2016
This reverts commit 6412fc0.
rohansingh
pushed a commit
that referenced
this pull request
Dec 13, 2016
This reverts commit 6412fc0.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a host is down, we still want the
RollingUndeployPlannerto attemptto undeploy from it, and then remove it from the list of removed hosts.
Otherwise, the list of removed hosts for a deployment group can grow
unboundedly.