CI Update #1502
Merged
CI Update #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f bash this fails with a syntax error
The test_all.sh script currently runs cpp tests using g++. This is not good for the following reasons: * During normal DaCe compilation we use cmake (and thus whatever compiler cmake picks up). * We don't check if g++ is available. This change uses whatever the user set as CXX env var. Cmake also uses CXX when it is set. Thus if a user sets CXX, he will use the same compiler for tests and during dace compilation. If CXX is not set we fall back to g++ as the hard-coded compiler. The test script also prints the current progress before each test now.
tbennun
reviewed
Jan 17, 2024
| python -m pip install --upgrade pip | ||
| pip install flake8 pytest-xdist coverage | ||
| pip install mpi4py | ||
| pip install cupy |
There was a problem hiding this comment.
this should be cupy-cuda<VERSION>. For example, cupy-cuda122 for CUDA 11.2. This avoids recompiling everything and taking a while.
There was a problem hiding this comment.
Wouldn't it be better to keep the dependencies updating over time? For most runs it will detect that it is already installed in the most up to date version.
There was a problem hiding this comment.
Sure. Sometimes cupy historically had issues to compile, but if it works it works.
tbennun
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.