Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaces replaced by "+" on Outlook.com #109

Closed
pcboii opened this issue Nov 8, 2020 · 3 comments
Closed

Spaces replaced by "+" on Outlook.com #109

pcboii opened this issue Nov 8, 2020 · 3 comments
Labels
bug

Comments

@pcboii
Copy link

pcboii commented Nov 8, 2020 •
edited
Loading

Context

  1. PHP Version: 7.4.2
  2. Package version: 1.4.2

Describe the Bug

  • Created a link.
  • Clicked on the generated Outlook Web link.
  • Noticed spaces in event title/description are replaced by "+".

Link Generated:
https://outlook.live.com/calendar/deeplink/compose?path=/calendar/action/compose&rru=addevent&startdt=2020-11-06T17:00:00Z&enddt=2020-11-06T18:00:00Z&subject=Appointment+with+Demo&body=Case+Number%3A+ABC-123

2020-11-07_19-12-04

Expected Behavior

Display a space rather than "+".
@pcboii pcboii added the bug label Nov 8, 2020
@glitcha
Copy link

glitcha commented Feb 2, 2021

Having this problem too

@glitcha
Copy link

glitcha commented Feb 2, 2021

I have had a lot better results by doing a str_replace on the resulting link to remove the following path=/calendar/action/compose&rru=addevent

Spaces as expected now.

iosley added a commit to iosley/calendar-links that referenced this issue Mar 2, 2021
@iosley
spatie#109 Fix spaces on Outlook
1e60b30
@iosley iosley mentioned this issue Mar 2, 2021
Merged
iosley added a commit to iosley/calendar-links that referenced this issue Mar 2, 2021
@iosley
spatie#109 Change expected url for Outlook test cases
9caa746
iosley added a commit to iosley/calendar-links that referenced this issue Mar 2, 2021
@iosley
spatie#109 Change expected url for Outlook test cases
cbc7b8d
iosley added a commit to iosley/calendar-links that referenced this issue Mar 5, 2021
@iosley
spatie#109 Improvements for "Fix spaces on Outlook web"
cb9707f 
- Improve the readability of the code and fix the missing character ";";
- List for future replacements;
- Cleanup HTML encode before URL encode.
alies-dev pushed a commit that referenced this issue Mar 5, 2021
@lptn
Merge pull request #115 from iosley/master
0586c13 
#109 Fix spaces on Outlook
@alies-dev
Copy link
Collaborator

fixed within latest release, thanks to @iosley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glitcha @alies-dev @pcboii