-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyvista 3 d visualization #48
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 86.86% 89.06% +2.20%
==========================================
Files 3 4 +1
Lines 236 311 +75
Branches 36 51 +15
==========================================
+ Hits 205 277 +72
Misses 22 22
- Partials 9 12 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks very nice!
it would be great if you could also add an example of using this functionality with sme to the plot notebook (which currently shows how to plot results from a 2d model, it would be nice to have the same for a 3d model with your new plotting functions):
- notebook: https://github.com/spatial-model-editor/sme-contrib/blob/main/docs/notebooks/plot.ipynb
- generated docs: https://sme-contrib.readthedocs.io/en/latest/notebooks/plot.html
and a related point: it's not immediately clear to me as a user how I should use these functions to plot the simulation results - would it be possible to adjust the API to take a sme.SimulationResult
similar to the existing 2d plotting functions? (see e.g.
https://sme-contrib.readthedocs.io/en/latest/_autosummary/sme_contrib.plot.concentration_heatmap.html)
facet_grid_3D
andfacet_grid_animate_3D
which work much like seaborn facetgrid, but as a function instead of a class.pyproject.toml
and the test gh workflow to support python3.9 to 3.13